User inputs are properly escaped (eg the correct param type is used and risky types such as raw are only used where necessary and safe to do so) and.Capabilities are checked where roles differ.Sesskey values are checked before all write actions where appropriate (some read actions as well).User login is checked where an identity is needed.The user community relies on Moodle being responsibly secure. Behat tests pass for related areas where changes have been made, especially when it involved UI changes.Unit tests pass for related areas where changes have been made.New unit tests have been added when there is a change in functionality and.The assignee has tested according to the instructions and verified that they are passing (This is the responsibility of the assignee, not the peer reviewer).They consider other perspectives of other users perhaps not considered by original developers e.g.Please ensure that the testing instructions: There are specific testing instructions that state how, as well as what, to test.Issues should not be sent for peer review without tests so that the peer reviewer can assess their quality and use them to consider the scope of the issue. It is the developer's responsibility to test code before integration. Testing instructions and automated tests
0 Comments
Leave a Reply. |